From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: WARNING: refcount bug in should_fail Date: Tue, 3 Apr 2018 06:20:09 +0100 Message-ID: <20180403052009.GH30522@ZenIV.linux.org.uk> References: <94eb2c0b816e88bfc50568c6fed5@google.com> <201804011941.IAE69652.OHMVJLFtSOFFQO@I-love.SAKURA.ne.jp> <87lge5z6yn.fsf@xmission.com> <20180402215212.GF30522@ZenIV.linux.org.uk> <20180402215934.GG30522@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Tetsuo Handa , syzbot+@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, dvyukov@google.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org To: "Eric W. Biederman" Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:44512 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753350AbeDCFUT (ORCPT ); Tue, 3 Apr 2018 01:20:19 -0400 Content-Disposition: inline In-Reply-To: <20180402215934.GG30522@ZenIV.linux.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > FWIW, I'm going through the ->kill_sb() instances, fixing that sort > of bugs (most of them preexisting, but I should've checked instead > of assuming that everything's fine). Will push out later tonight. OK, see vfs.git#for-linus. Caught: 4 old bugs (allocation failure in fill_super oopses ->kill_sb() in hypfs, jffs2 and orangefs resp. and double-dput in late failure exit in rpc_fill_super()) and 5 regressions from register_shrinker() failure recovery.