From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC PATCH 3/3] virtio_net: make lower netdevs for virtio_bypass hidden Date: Tue, 3 Apr 2018 15:20:27 +0300 Message-ID: <20180403151915-mutt-send-email-mst@kernel.org> References: <1522573990-5242-1-git-send-email-si-wei.liu@oracle.com> <1522573990-5242-4-git-send-email-si-wei.liu@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jiri@resnulli.us, stephen@networkplumber.org, alexander.h.duyck@intel.com, davem@davemloft.net, jesse.brandeburg@intel.com, kubakici@wp.pl, jasowang@redhat.com, sridhar.samudrala@intel.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org To: Si-Wei Liu Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:54804 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932069AbeDCMUa (ORCPT ); Tue, 3 Apr 2018 08:20:30 -0400 Content-Disposition: inline In-Reply-To: <1522573990-5242-4-git-send-email-si-wei.liu@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Apr 01, 2018 at 05:13:10AM -0400, Si-Wei Liu wrote: > diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h > index aa40664..0827b7e 100644 > --- a/include/uapi/linux/virtio_net.h > +++ b/include/uapi/linux/virtio_net.h > @@ -80,6 +80,8 @@ struct virtio_net_config { > __u16 max_virtqueue_pairs; > /* Default maximum transmit unit advice */ > __u16 mtu; > + /* Device at bus:slot.function backed up by virtio_net */ > + __u16 bsf2backup; > } __attribute__((packed)); I'm not sure this is a good interface. This isn't unique even on some PCI systems, not to speak of non-PCI ones. > /* > -- > 1.8.3.1