Netdev List
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.h.duyck@intel.com>
To: intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org
Subject: [iwl next-queue PATCH 05/10] macvlan: macvlan_count_rx shouldn't be static inline AND extern
Date: Tue, 03 Apr 2018 17:16:19 -0400	[thread overview]
Message-ID: <20180403211619.7880.24524.stgit@ahduyck-green-test.jf.intel.com> (raw)
In-Reply-To: <20180403211519.7880.70243.stgit@ahduyck-green-test.jf.intel.com>

It doesn't make sense to define macvlan_count_rx as a static inline and
then add a forward declaration after that as an extern. I am dropping the
extern declaration since it seems like it is something that likely got
missed when the function was made an inline.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
 include/linux/if_macvlan.h |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/linux/if_macvlan.h b/include/linux/if_macvlan.h
index c5106ce..80089d6 100644
--- a/include/linux/if_macvlan.h
+++ b/include/linux/if_macvlan.h
@@ -61,10 +61,6 @@ extern int macvlan_common_newlink(struct net *src_net, struct net_device *dev,
 				  struct nlattr *tb[], struct nlattr *data[],
 				  struct netlink_ext_ack *extack);
 
-extern void macvlan_count_rx(const struct macvlan_dev *vlan,
-			     unsigned int len, bool success,
-			     bool multicast);
-
 extern void macvlan_dellink(struct net_device *dev, struct list_head *head);
 
 extern int macvlan_link_register(struct rtnl_link_ops *ops);

  parent reply	other threads:[~2018-04-03 21:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03 21:15 [iwl next-queue PATCH 00/10] Clean-up macvlan offloading Alexander Duyck
2018-04-03 21:15 ` [iwl next-queue PATCH 01/10] ixgbe: Drop support for macvlan specific unicast lists Alexander Duyck
2018-04-03 21:16 ` [iwl next-queue PATCH 02/10] macvlan: Rename fwd_priv to accel_priv and add accessor function Alexander Duyck
2018-04-04 16:53   ` [Intel-wired-lan] " Shannon Nelson
2018-04-04 17:33     ` Alexander Duyck
2018-04-03 21:16 ` [iwl next-queue PATCH 03/10] macvlan: Use software path for offloaded local, broadcast, and multicast traffic Alexander Duyck
2018-04-04 16:53   ` [Intel-wired-lan] " Shannon Nelson
2018-04-04 17:02     ` Alexander Duyck
2018-04-03 21:16 ` [iwl next-queue PATCH 04/10] ixgbe/fm10k: Drop tracking stats for macvlan broadcast/multicast Alexander Duyck
2018-04-03 21:16 ` Alexander Duyck [this message]
2018-04-03 21:16 ` [iwl next-queue PATCH 06/10] macvlan: Add function to test for destination filtering support Alexander Duyck
2018-04-03 21:16 ` [iwl next-queue PATCH 07/10] macvlan: Provide function for interfaces to release HW offload Alexander Duyck
2018-04-03 21:16 ` [iwl next-queue PATCH 08/10] ixgbe/fm10k: Only support macvlan offload for types that support destination filtering Alexander Duyck
2018-04-03 21:16 ` [iwl next-queue PATCH 09/10] ixgbe: Drop real_adapter from l2 fwd acceleration structure Alexander Duyck
2018-04-03 21:16 ` [iwl next-queue PATCH 10/10] ixgbe: Avoid performing unnecessary resets for macvlan offload Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180403211619.7880.24524.stgit@ahduyck-green-test.jf.intel.com \
    --to=alexander.h.duyck@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox