From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net v6 0/4] ipv6: udp: set dst cache for a connected sk if current not valid Date: Wed, 04 Apr 2018 11:32:25 -0400 (EDT) Message-ID: <20180404.113225.251920716857478256.davem@davemloft.net> References: <1522756810-24985-1-git-send-email-alexey.kodanev@oracle.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, edumazet@google.com, kafai@fb.com To: alexey.kodanev@oracle.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:40270 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbeDDPc1 (ORCPT ); Wed, 4 Apr 2018 11:32:27 -0400 In-Reply-To: <1522756810-24985-1-git-send-email-alexey.kodanev@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Alexey Kodanev Date: Tue, 3 Apr 2018 15:00:06 +0300 > A new RTF_CACHE route can be created with the socket's dst cache > update between the below calls in udpv6_sendmsg(), when datagram > sending results to ICMPV6_PKT_TOOBIG error: > > dst = ip6_sk_dst_lookup_flow(...) > ... > release_dst: > if (dst) { > if (connected) { > ip6_dst_store(sk, dst) > > Therefore, the new socket's dst cache reset to the old one on > "release_dst:". > > The first three patches prepare the code to store dst cache > with ip6_sk_dst_lookup_flow(): ... > The last patch contains the actual fix that removes sk dst cache > update in the end of udpv6_sendmsg(), and allows to do it in > ip6_sk_dst_lookup_flow(). Looks good, applied and queued up for -stable. Thanks!