From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] nfp: use full 40 bits of the NSP buffer address Date: Wed, 04 Apr 2018 11:45:44 -0400 (EDT) Message-ID: <20180404.114544.2066742718526709623.davem@davemloft.net> References: <20180404002423.6422-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: oss-drivers@netronome.com, netdev@vger.kernel.org, dirk.vandermerwe@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:40480 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbeDDPpq (ORCPT ); Wed, 4 Apr 2018 11:45:46 -0400 In-Reply-To: <20180404002423.6422-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Tue, 3 Apr 2018 17:24:23 -0700 > From: Dirk van der Merwe > > The NSP default buffer is a piece of NFP memory where additional > command data can be placed. Its format has been copied from > host buffer, but the PCIe selection bits do not make sense in > this case. If those get masked out from a NFP address - writes > to random place in the chip memory may be issued and crash the > device. > > Even in the general NSP buffer case, it doesn't make sense to have the > PCIe selection bits there anymore. These are unused at the moment, and > when it becomes necessary, the PCIe selection bits should rather be > moved to another register to utilise more bits for the buffer address. > > This has never been an issue because the buffer used to be > allocated in memory with less-than-38-bit-long address but that > is about to change. > > Fixes: 1a64821c6af7 ("nfp: add support for service processor access") > Signed-off-by: Dirk van der Merwe > Reviewed-by: Jakub Kicinski Applied and queued up for -stable, thanks.