From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net-next 1/1] tipc: Fix namespace violation in tipc_sk_fill_sock_diag Date: Wed, 04 Apr 2018 11:55:00 -0400 (EDT) Message-ID: <20180404.115500.1023819771199667056.davem@davemloft.net> References: <1522846187-23914-1-git-send-email-mohan.krishna.ghanta.krishnamurthy@ericsson.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: tipc-discussion@lists.sourceforge.net, jon.maloy@ericsson.com, maloy@donjonn.com, ying.xue@windriver.com, netdev@vger.kernel.org To: mohan.krishna.ghanta.krishnamurthy@ericsson.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:40694 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751582AbeDDPzC (ORCPT ); Wed, 4 Apr 2018 11:55:02 -0400 In-Reply-To: <1522846187-23914-1-git-send-email-mohan.krishna.ghanta.krishnamurthy@ericsson.com> Sender: netdev-owner@vger.kernel.org List-ID: From: GhantaKrishnamurthy MohanKrishna Date: Wed, 4 Apr 2018 14:49:47 +0200 > To fetch UID info for socket diagnostics, we determine the > namespace of user context using tipc socket instance. This > may cause namespace violation, as the kernel will remap based > on UID. > > We fix this by fetching namespace info using the calling userspace > netlink socket. > > Fixes: c30b70deb5f4 (tipc: implement socket diagnostics for AF_TIPC) > Reported-by: syzbot+326e587eff1074657718@syzkaller.appspotmail.com > Acked-by: Jon Maloy > Signed-off-by: GhantaKrishnamurthy MohanKrishna Applied, thank you.