From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: brouer@redhat.com, alexander.duyck@gmail.com,
oss-drivers@netronome.com,
Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [RFC] net: bump the default number of RSS queues
Date: Tue, 3 Apr 2018 17:14:22 -0700 [thread overview]
Message-ID: <20180404001422.6080-1-jakub.kicinski@netronome.com> (raw)
Some popular NIC vendors are not adhering to
netif_get_num_default_rss_queues() which leads to users being
surprised and filing bugs :) Bump the number of default RX
queues to something more reasonable for modern machines.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
---
I'm mostly wondering what's the policy on this default? When
should it be applied? Why was 8 chosen as the default? We
can abandon using netif_get_num_default_rss_queues() for the
nfp but I wonder what's the correct course of action here...
Should new drivers use netif_get_num_default_rss_queues() for
example?
include/linux/netdevice.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 2a2d9cf50aa2..26fe145ada2a 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -3260,7 +3260,7 @@ static inline unsigned int get_netdev_rx_queue_index(
}
#endif
-#define DEFAULT_MAX_NUM_RSS_QUEUES (8)
+#define DEFAULT_MAX_NUM_RSS_QUEUES (64)
int netif_get_num_default_rss_queues(void);
enum skb_free_reason {
--
2.16.2
next reply other threads:[~2018-04-04 0:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 0:14 Jakub Kicinski [this message]
2018-04-04 0:20 ` [RFC] net: bump the default number of RSS queues Eric Dumazet
2018-04-05 0:08 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404001422.6080-1-jakub.kicinski@netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=alexander.duyck@gmail.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox