From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice
Date: Wed, 4 Apr 2018 08:19:45 +0200
Message-ID: <20180404061945.GN3313@nanopsycho>
References: <1522573990-5242-1-git-send-email-si-wei.liu@oracle.com>
 <1522573990-5242-3-git-send-email-si-wei.liu@oracle.com>
 <8b589cd2-1abc-59c2-99f1-96df8174bb6b@gmail.com>
 <20180403154210.GK3313@nanopsycho>
 <3bdfc39f-4935-2433-7982-9ce28c3aa166@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Si-Wei Liu <si-wei.liu@oracle.com>, mst@redhat.com,
        stephen@networkplumber.org, alexander.h.duyck@intel.com,
        davem@davemloft.net, jesse.brandeburg@intel.com, kubakici@wp.pl,
        jasowang@redhat.com, sridhar.samudrala@intel.com,
        netdev@vger.kernel.org, virtualization@lists.linux-foundation.org,
        virtio-dev@lists.oasis-open.org
To: David Ahern <dsahern@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f196.google.com ([209.85.128.196]:43785 "EHLO
        mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751098AbeDDGTs (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 4 Apr 2018 02:19:48 -0400
Received: by mail-wr0-f196.google.com with SMTP id p53so20791411wrc.10
        for <netdev@vger.kernel.org>; Tue, 03 Apr 2018 23:19:47 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <3bdfc39f-4935-2433-7982-9ce28c3aa166@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Wed, Apr 04, 2018 at 03:04:26AM CEST, dsahern@gmail.com wrote:
>On 4/3/18 9:42 AM, Jiri Pirko wrote:
>>>
>>> There are other use cases that want to hide a device from userspace. I
>> 
>> What usecases do you have in mind?
>
>As mentioned in a previous response some kernel drivers create control
>netdevs. Just as in this case users should not be mucking with it, and

virtio_net. Any other drivers?


>S/W like lldpd should ignore it.

It's just a matter of identification of the netdevs, so the user knows
what to do.


>
>> 
>>> would prefer a better solution than playing games with name prefixes and
>>> one that includes an API for users to list all devices -- even ones
>>> hidden by default.
>> 
>> Netdevice hiding feels a bit scarry for me. This smells like a workaround
>> for userspace issues. Why can't the netdevice be visible always and
>> userspace would know what is it and what should it do with it?
>> 
>> Once we start with hiding, there are other things related to that which
>> appear. Like who can see what, levels of visibility etc...
>> 
>
>I would not advocate for any API that does not allow users to have full
>introspection. The intent is to hide the netdev by default but have an
>option to see it.

As an administrator, I want to see all by default. I think it is
reasonable requirements. Again, this awfully smells like a workaround...