From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-next] tc: Correct json output for actions
Date: Wed, 4 Apr 2018 16:42:21 -0700
Message-ID: <20180404164221.019242d1@xeon-e3>
References: <1522844653-37136-1-git-send-email-yuvalm@mellanox.com>
        <858ta2brwv.fsf@mojatatu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Yuval Mintz <yuvalm@mellanox.com>, dsahern@gmail.com,
        mlxsw@mellanox.com, netdev@vger.kernel.org
To: Roman Mashak <mrv@mojatatu.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f44.google.com ([209.85.160.44]:39573 "EHLO
        mail-pl0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752395AbeDDXm0 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 4 Apr 2018 19:42:26 -0400
Received: by mail-pl0-f44.google.com with SMTP id s24-v6so16449625plq.6
        for <netdev@vger.kernel.org>; Wed, 04 Apr 2018 16:42:26 -0700 (PDT)
In-Reply-To: <858ta2brwv.fsf@mojatatu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 04 Apr 2018 17:09:04 -0400
Roman Mashak <mrv@mojatatu.com> wrote:

> Yuval Mintz <yuvalm@mellanox.com> writes:
> 
> > Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON
> > support for tc-actions at the expense of breaking other use cases that
> > reach tc_print_action(), as the latter don't expect the 'actions' array
> > to be a new object.
> >
> > Consider the following taken duringrun of tc_chain.sh selftest,
> > and see the latter command output is broken:
> >
> > $ ./tc/tc -j -p actions list action gact | grep -C 3 actions
> > [ {
> >         "total acts": 1
> >     },{
> >         "actions": [ {
> >                 "order": 0,
> >
> > $ ./tc/tc -p -j -s filter show dev enp3s0np2 ingress | grep -C 3 actions
> >             },
> >             "skip_hw": true,
> >             "not_in_hw": true,{
> >                 "actions": [ {
> >                         "order": 1,
> >                         "kind": "gact",
> >                         "control_action": {
> >
> > Relocate the open/close of the JSON object to declare the object only
> > for the case that needs it.
> >
> > Signed-off-by: Yuval Mintz <yuvalm@mellanox.com>  
> 
> [...]
> 
> 
> Good catch, thanks Yuval.
> 
> Tested-by: Roman Mashak <mrv@mojatatu.com>

Applied