From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] ip/l2tp: remove offset and peer-offset options Date: Wed, 4 Apr 2018 16:43:10 -0700 Message-ID: <20180404164310.43259e82@xeon-e3> References: <46d360e852235de84e44c796fa934f9cfce988b1.1522769819.git.g.nault@alphalink.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, James Chapman To: Guillaume Nault Return-path: Received: from mail-pl0-f45.google.com ([209.85.160.45]:44337 "EHLO mail-pl0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395AbeDDXnN (ORCPT ); Wed, 4 Apr 2018 19:43:13 -0400 Received: by mail-pl0-f45.google.com with SMTP id b6-v6so14474809pla.11 for ; Wed, 04 Apr 2018 16:43:12 -0700 (PDT) In-Reply-To: <46d360e852235de84e44c796fa934f9cfce988b1.1522769819.git.g.nault@alphalink.fr> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 3 Apr 2018 17:39:54 +0200 Guillaume Nault wrote: > Ignore options "peer-offset" and "offset" when creating sessions. Keep > them when dumping sessions in order to avoid breaking external scripts. > > "peer-offset" has always been a noop in iproute2. "offset" is now > ignored in Linux 4.16 (and was broken before that). > > Signed-off-by: Guillaume Nault Sure, this makes sense applied. In theory, you could have just dropped them from the JSON output.