From: Andrew Lunn <andrew@lunn.ch>
To: Raghuram Chary J <raghuramchary.jallipalli@microchip.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
unglinuxdriver@microchip.com, woojung.huh@microchip.com
Subject: Re: [PATCH ethtool] ethtool: Add register dump support for MICROCHIP LAN78xx
Date: Thu, 5 Apr 2018 14:37:22 +0200 [thread overview]
Message-ID: <20180405123722.GD12178@lunn.ch> (raw)
In-Reply-To: <20180405061128.5479-1-raghuramchary.jallipalli@microchip.com>
On Thu, Apr 05, 2018 at 11:41:28AM +0530, Raghuram Chary J wrote:
Hi Raghuram
> + fprintf(stdout, "PHY Registers:\n");
> + fprintf(stdout, "--------------\n");
> + fprintf(stdout, "Mode Control = 0x%04X\n", *lan78xx_reg++);
> + fprintf(stdout, "Mode Status = 0x%04X\n", *lan78xx_reg++);
> + fprintf(stdout, "Device identifier1 = 0x%04X\n", *lan78xx_reg++);
> + fprintf(stdout, "Device identifier2 = 0x%04X\n", *lan78xx_reg++);
> + fprintf(stdout, "Auto-Neg Advertisement = 0x%04X\n",
> + *lan78xx_reg++);
> + fprintf(stdout, "Auto-Neg Link Partner Ability = 0x%04X\n",
> + *lan78xx_reg++);
> + fprintf(stdout, "Auto-Neg Expansion = 0x%04X\n", *lan78xx_reg++);
> + fprintf(stdout, "Auto-Neg Next Page TX = 0x%04X\n", *lan78xx_reg++);
> + fprintf(stdout, "Auto-Neg Link Partner Next Page RX = 0x%04X\n",
> + *lan78xx_reg++);
> + fprintf(stdout, "1000BASE-T Control = 0x%04X\n", *lan78xx_reg++);
> + fprintf(stdout, "1000BASE-T Status = 0x%04X\n", *lan78xx_reg++);
> + fprintf(stdout, "Reserved = 0x%04X\n", *lan78xx_reg++);
> + fprintf(stdout, "Reserved = 0x%04X\n", *lan78xx_reg++);
> + fprintf(stdout, "MMD Access Control = 0x%04X\n", *lan78xx_reg++);
> + fprintf(stdout, "MMD Access Address/Data = 0x%04X\n", *lan78xx_reg++);
Do the above registers conform to the normal MII definitions? Have you
looked at the code in netsemi.c? Maybe a generic helper can be defined
which dumps standard PHY registers?
Andrew
next prev parent reply other threads:[~2018-04-05 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 6:11 [PATCH ethtool] ethtool: Add register dump support for MICROCHIP LAN78xx Raghuram Chary J
2018-04-05 12:37 ` Andrew Lunn [this message]
2018-04-16 17:57 ` [ethtool] " John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405123722.GD12178@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=raghuramchary.jallipalli@microchip.com \
--cc=unglinuxdriver@microchip.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).