From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: [PATCH net 1/6] net: fool proof dev_valid_name() Date: Thu, 5 Apr 2018 06:39:26 -0700 Message-ID: <20180405133931.207634-2-edumazet@google.com> References: <20180405133931.207634-1-edumazet@google.com> Cc: netdev , Steffen Klassert , Eric Dumazet , Eric Dumazet To: "David S . Miller" Return-path: Received: from mail-pl0-f65.google.com ([209.85.160.65]:43617 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbeDENjk (ORCPT ); Thu, 5 Apr 2018 09:39:40 -0400 Received: by mail-pl0-f65.google.com with SMTP id c21-v6so15521377plz.10 for ; Thu, 05 Apr 2018 06:39:40 -0700 (PDT) In-Reply-To: <20180405133931.207634-1-edumazet@google.com> Sender: netdev-owner@vger.kernel.org List-ID: We want to use dev_valid_name() to validate tunnel names, so better use strnlen(name, IFNAMSIZ) than strlen(name) to make sure to not upset KASAN. Signed-off-by: Eric Dumazet --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 9b04a9fd1dfd0e065a7fe798dd840a07f0e0a4df..969462ebb296250fe5f3b7c4621e9ba9720a2dbe 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1027,7 +1027,7 @@ bool dev_valid_name(const char *name) { if (*name == '\0') return false; - if (strlen(name) >= IFNAMSIZ) + if (strnlen(name, IFNAMSIZ) == IFNAMSIZ) return false; if (!strcmp(name, ".") || !strcmp(name, "..")) return false; -- 2.17.0.484.g0c8726318c-goog