From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] net: thunderx: rework mac addresses list to u64 array Date: Thu, 5 Apr 2018 08:07:48 -0700 Message-ID: <20180405150748.GA5716@infradead.org> References: <20180405145756.12633-1-Vadim.Lomovtsev@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: sgoutham@cavium.com, sunil.kovvuri@gmail.com, robert.richter@kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, dnelson@redhat.com, gustavo@embeddedor.com, Vadim Lomovtsev To: Vadim Lomovtsev Return-path: Content-Disposition: inline In-Reply-To: <20180405145756.12633-1-Vadim.Lomovtsev@caviumnetworks.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > struct xcast_addr_list { > - struct list_head list; > int count; > + u64 mc[0]; Please use the standard C99 syntax here: u64 mc[]; > + mc_list = kmalloc(sizeof(*mc_list) + > + sizeof(u64) * netdev_mc_count(netdev), > + GFP_ATOMIC); kmalloc_array(), please.