From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink Date: Fri, 6 Apr 2018 07:52:55 +0200 Message-ID: <20180406055255.GB19345@nanopsycho> References: <20180328012200.15175-1-dsa@cumulusnetworks.com> <20180328012200.15175-7-dsa@cumulusnetworks.com> <20180405172718.GA9125@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, shm@cumulusnetworks.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, andy.roulin@gmail.com To: David Ahern Return-path: Received: from mail-wr0-f171.google.com ([209.85.128.171]:47048 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbeDFFw5 (ORCPT ); Fri, 6 Apr 2018 01:52:57 -0400 Received: by mail-wr0-f171.google.com with SMTP id d1so36083wrj.13 for ; Thu, 05 Apr 2018 22:52:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Thu, Apr 05, 2018 at 11:06:41PM CEST, dsa@cumulusnetworks.com wrote: >On 4/5/18 2:10 PM, David Ahern wrote: >> >> The ASIC here is the kernel tables in a namespace. It does not make >> sense to have 2 devlink instances for a single namespace. > >I put this example controller in netdevsim per a suggestion from Ido. >The netdevsim seemed like a good idea given that modules intention -- >testing network facilities. Perhaps I should have done this as a >completely standalone module ... > >The intention is to treat the kernel's tables *per namespace* as a >standalone entity that can be managed very similar to ASIC resources. So you say you want to treat a namespace as an ASIC? That sounds very odd to me :/ >Given that I can add a resource controller module >(drivers/net/kern_res_mgr.c?) that creates a 'struct device' per network >namespace with a devlink instance. In this case the device would very >much be tied to the namespace 1:1. That sounds more reasonable and accurate, yet still odd. You would not have any netdevices there? Any ports?