From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net 2/3] lan78xx: Add support to dump lan78xx registers
Date: Fri, 6 Apr 2018 16:40:33 +0200
Message-ID: <20180406144033.GM17495@lunn.ch>
References: <20180406061204.18257-1-raghuramchary.jallipalli@microchip.com>
 <20180406061204.18257-3-raghuramchary.jallipalli@microchip.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: davem@davemloft.net, netdev@vger.kernel.org,
        unglinuxdriver@microchip.com, woojung.huh@microchip.com
To: Raghuram Chary J <raghuramchary.jallipalli@microchip.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:52408 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752401AbeDFOkf (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 6 Apr 2018 10:40:35 -0400
Content-Disposition: inline
In-Reply-To: <20180406061204.18257-3-raghuramchary.jallipalli@microchip.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> +static int lan78xx_get_regs_len(struct net_device *netdev)
> +{
> +	return (sizeof(lan78xx_regs) + PHY_REG_SIZE);

If there is no PHY attached, you probably should not include
PHY_REG_SIZE here.

     Andrew