From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: [Patch net] net_sched: fix a missing idr_remove() in u32_delete_key() Date: Fri, 6 Apr 2018 17:19:41 -0700 Message-ID: <20180407001941.10752-1-xiyou.wangcong@gmail.com> Cc: Cong Wang , Linus Torvalds , Jamal Hadi Salim To: netdev@vger.kernel.org Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:36924 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751528AbeDGATr (ORCPT ); Fri, 6 Apr 2018 20:19:47 -0400 Received: by mail-pf0-f196.google.com with SMTP id x16so1863025pfm.4 for ; Fri, 06 Apr 2018 17:19:47 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: When we delete a u32 key via u32_delete_key(), we forget to call idr_remove() to remove its handle from IDR. Fixes: e7614370d6f0 ("net_sched: use idr to allocate u32 filter handles") Reported-by: Marcin Kabiesz Cc: Linus Torvalds Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/cls_u32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index ed8b6a24b9e9..bac47b5d18fd 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -489,6 +489,7 @@ static int u32_delete_key(struct tcf_proto *tp, struct tc_u_knode *key) RCU_INIT_POINTER(*kp, key->next); tcf_unbind_filter(tp, &key->res); + idr_remove(&ht->handle_idr, key->handle); tcf_exts_get_net(&key->exts); call_rcu(&key->rcu, u32_delete_key_freepf_rcu); return 0; -- 2.13.0