From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: Enable and configure storm prevention in a network device
Date: Mon, 9 Apr 2018 17:18:31 +0200
Message-ID: <20180409151831.GD562@lunn.ch>
References: <76c2b7c7-4f85-c81e-c928-e5650cc26b93@ti.com>
 <20180405.162031.2009953983418308744.davem@davemloft.net>
 <75eb56a4-ded2-5ed5-116c-776312f93cf3@gmail.com>
 <20180406143021.GK17495@lunn.ch>
 <51604140-bafe-2fd6-65b1-0a3b732c83bd@ti.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>, netdev@vger.kernel.org
To: Murali Karicheri <m-karicheri2@ti.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:54117 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753038AbeDIPSg (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 9 Apr 2018 11:18:36 -0400
Content-Disposition: inline
In-Reply-To: <51604140-bafe-2fd6-65b1-0a3b732c83bd@ti.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> > The Marvell switches have leaky buckets, which can be used for
> > limiting broadcast and multicast packets, as well as traffic shaping
> > in general. Storm prevention is just a form of traffic shaping, so if
> > we have generic traffic shaping, it can be used for storm prevention.
> > 
> TI's CPSW hardware as well has similar capability to limit broadcast and
> multicast packets at the ingress. Isn't it a traffic policing at the Ingress
> rather than traffic shaping as the hardware drops the frames at the ingress
> if the rate exceeds a limit?

Hi Murali

It depends on the generation of Marvell switches. Older ones have just
egress traffic shaping. Newer ones also have ingress rate limiting.

       Andrew