From: David Miller <davem@davemloft.net>
To: tejaswit@codeaurora.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] slip: Check if rstate is initialized before uncompressing
Date: Tue, 10 Apr 2018 10:03:16 -0400 (EDT) [thread overview]
Message-ID: <20180410.100316.1025191508156853437.davem@davemloft.net> (raw)
In-Reply-To: <ed7bd53914f26c2225c6c00d16bffb35@codeaurora.org>
From: tejaswit@codeaurora.org
Date: Tue, 10 Apr 2018 11:28:10 +0530
> On 2018-04-09 20:34, David Miller wrote:
>> From: Tejaswi Tanikella <tejaswit@codeaurora.org>
>> Date: Mon, 9 Apr 2018 14:23:49 +0530
>>
>>> @@ -673,6 +677,7 @@ struct slcompress *
>>> if (cs->cs_tcp.doff > 5)
>>> memcpy(cs->cs_tcpopt, icp + ihl*4 + sizeof(struct tcphdr),
>>> (cs->cs_tcp.doff - 5) * 4);
>>> cs->cs_hsize = ihl*2 + cs->cs_tcp.doff*2;
>>> + cs->initialized = 1;
>>> /* Put headers back on packet
>> ...
>>> struct cstate {
>>> byte_t cs_this; /* connection id number (xmit) */
>>> + byte_t initialized; /* non-zero if initialized */
>> Please use 'bool' and true/false for 'initialized'.
>
> Made the changes.
Please, when you are asked to fix a patch, post it as a new posting
with '[PATCH v2 net] slip: ...' in the subject line.
And also not as an attachment, all patches must be inline.
Thank you.
prev parent reply other threads:[~2018-04-10 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 8:53 [PATCH] slip: Check if rstate is initialized before uncompressing Tejaswi Tanikella
2018-04-09 15:04 ` David Miller
2018-04-10 5:58 ` tejaswit
2018-04-10 9:48 ` Guillaume Nault
2018-04-10 14:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410.100316.1025191508156853437.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tejaswit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).