From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] slip: Check if rstate is initialized before
 uncompressing
Date: Tue, 10 Apr 2018 10:03:16 -0400 (EDT)
Message-ID: <20180410.100316.1025191508156853437.davem@davemloft.net>
References: <20180409085345.GA5972@tejaswit-linux.qualcomm.com>
        <20180409.110438.458180702294361660.davem@davemloft.net>
        <ed7bd53914f26c2225c6c00d16bffb35@codeaurora.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: tejaswit@codeaurora.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:52412 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753081AbeDJODU (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 10 Apr 2018 10:03:20 -0400
In-Reply-To: <ed7bd53914f26c2225c6c00d16bffb35@codeaurora.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: tejaswit@codeaurora.org
Date: Tue, 10 Apr 2018 11:28:10 +0530

> On 2018-04-09 20:34, David Miller wrote:
>> From: Tejaswi Tanikella <tejaswit@codeaurora.org>
>> Date: Mon, 9 Apr 2018 14:23:49 +0530
>> 
>>> @@ -673,6 +677,7 @@ struct slcompress *
>>>  	if (cs->cs_tcp.doff > 5)
>>>  	  memcpy(cs->cs_tcpopt, icp + ihl*4 + sizeof(struct tcphdr),
>>>  	  (cs->cs_tcp.doff - 5) * 4);
>>>  	cs->cs_hsize = ihl*2 + cs->cs_tcp.doff*2;
>>> +	cs->initialized = 1;
>>>  	/* Put headers back on packet
>>  ...
>>>  struct cstate {
>>>  	byte_t	cs_this;	/* connection id number (xmit) */
>>> +	byte_t	initialized;	/* non-zero if initialized */
>> Please use 'bool' and true/false for 'initialized'.
> 
> Made the changes.

Please, when you are asked to fix a patch, post it as a new posting
with '[PATCH v2 net] slip: ...' in the subject line.

And also not as an attachment, all patches must be inline.

Thank you.