From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ip_gre: clear feature flags when incompatible o_flags are set Date: Tue, 10 Apr 2018 11:04:35 -0400 (EDT) Message-ID: <20180410.110435.2099683036018893839.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, lorenzo.bianconi@redhat.com, lucien.xin@gmail.com, u9012063@gmail.com To: sd@queasysnail.net Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:53440 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753202AbeDJPEh (ORCPT ); Tue, 10 Apr 2018 11:04:37 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Sabrina Dubroca Date: Tue, 10 Apr 2018 12:57:18 +0200 > Commit dd9d598c6657 ("ip_gre: add the support for i/o_flags update via > netlink") added the ability to change o_flags, but missed that the > GSO/LLTX features are disabled by default, and only enabled some gre > features are unused. Thus we also need to disable the GSO/LLTX features > on the device when the TUNNEL_SEQ or TUNNEL_CSUM flags are set. > > These two examples should result in the same features being set: > > ip link add gre_none type gre local 192.168.0.10 remote 192.168.0.20 ttl 255 key 0 > > ip link set gre_none type gre seq > ip link add gre_seq type gre local 192.168.0.10 remote 192.168.0.20 ttl 255 key 1 seq > > Fixes: dd9d598c6657 ("ip_gre: add the support for i/o_flags update via netlink") > Signed-off-by: Sabrina Dubroca Applied and queued up for -stable, thank you.