From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH] net: usb: hso: Replace GFP_ATOMIC with GFP_KERNEL in hso_create_device Date: Tue, 10 Apr 2018 16:59:28 +0200 Message-ID: <20180410145928.GC10795@localhost> References: <1523370924-32425-1-git-send-email-baijiaju1990@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, andreas@kemnade.info, johan@kernel.org, johannes.berg@intel.com, stephen@networkplumber.org, Linyu.Yuan@alcatel-sbell.com.cn, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Jia-Ju Bai Return-path: Content-Disposition: inline In-Reply-To: <1523370924-32425-1-git-send-email-baijiaju1990@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Apr 10, 2018 at 10:35:24PM +0800, Jia-Ju Bai wrote: > hso_create_device() is never called in atomic context. > > The call chains ending up at hso_create_device() are: > [1] hso_create_device() <- hso_create_bulk_serial_device() <- hso_probe() > [2] hso_create_device() <- hso_create_mux_serial_device() <- hso_probe() > [3] hso_create_device() <- hso_create_net_device() <- hso_probe() > hso_probe() is set as ".probe" in struct usb_driver, > so it is not called in atomic context. > > Despite never getting called from atomic context, > hso_create_device() calls kzalloc() with GFP_ATOMIC, > which does not sleep for allocation. > GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, > which can sleep and improve the possibility of sucessful allocation. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai Thanks for the patch. This looks good to me. Reviewed-by: Johan Hovold Johan