From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] lan78xx: Correctly indicate invalid OTP
Date: Wed, 11 Apr 2018 10:31:27 -0400 (EDT)
Message-ID: <20180411.103127.1511048337167278763.davem@davemloft.net>
References: <1523440757-127451-1-git-send-email-phil@raspberrypi.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
        netdev@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
To: phil@raspberrypi.org
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1523440757-127451-1-git-send-email-phil@raspberrypi.org>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: Phil Elwell <phil@raspberrypi.org>
Date: Wed, 11 Apr 2018 10:59:17 +0100

> lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP
> content, but the value gets overwritten before it is returned and the
> read goes ahead anyway. Make the read conditional as it should be
> and preserve the error code.
> 
> Signed-off-by: Phil Elwell <phil@raspberrypi.org>

Applied with appropriate Fixes: tag added, and queud up for -stable.

Thanks.