From: David Miller <davem@davemloft.net>
To: tejaswit@codeaurora.org
Cc: netdev@vger.kernel.org, g.nault@alphalink.fr
Subject: Re: [PATCH v2 net] slip: Check if rstate is initialized before uncompressing
Date: Wed, 11 Apr 2018 10:34:11 -0400 (EDT) [thread overview]
Message-ID: <20180411.103411.2212608868988995529.davem@davemloft.net> (raw)
In-Reply-To: <20180411110441.GA4678@tejaswit-linux.qualcomm.com>
From: Tejaswi Tanikella <tejaswit@codeaurora.org>
Date: Wed, 11 Apr 2018 16:34:47 +0530
> On receiving a packet the state index points to the rstate which must be
> used to fill up IP and TCP headers. But if the state index points to a
> rstate which is unitialized, i.e. filled with zeros, it gets stuck in an
> infinite loop inside ip_fast_csum trying to compute the ip checsum of a
> header with zero length.
...
> Adding a variable to indicate if the current rstate is initialized. If
> such a packet arrives, move to toss state.
>
> Signed-off-by: Tejaswi Tanikella <tejaswit@codeaurora.org>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2018-04-11 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 11:04 [PATCH v2 net] slip: Check if rstate is initialized before uncompressing Tejaswi Tanikella
2018-04-11 14:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411.103411.2212608868988995529.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=g.nault@alphalink.fr \
--cc=netdev@vger.kernel.org \
--cc=tejaswit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).