From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH linux] net: fix deadlock while clearing neighbor proxy table Date: Wed, 11 Apr 2018 10:38:42 -0400 (EDT) Message-ID: <20180411.103842.746194578827934957.davem@davemloft.net> References: <20180410091514.28704-1-w.bumiller@proxmox.com> <20180410.110229.1597289057689247263.davem@davemloft.net> <5acdfcbd910c6_a7b2ac7838cb0d497@olga.notmuch> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org To: w.bumiller@proxmox.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:41342 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753693AbeDKOin (ORCPT ); Wed, 11 Apr 2018 10:38:43 -0400 In-Reply-To: <5acdfcbd910c6_a7b2ac7838cb0d497@olga.notmuch> Sender: netdev-owner@vger.kernel.org List-ID: From: Wolfgang Bumiller Date: Wed, 11 Apr 2018 14:17:01 +0200 > David Miller wrote: >> Another way is to rename pneigh_ifdown() to "pneigh_ifdown_and_unlock()". > > Sure, I can send a v2 with whichever is preferred - personally I prefer > the rename as it'll be visible at both the calling & implementation > side. Yeah the rename is probably best.