From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] lan78xx: Don't reset the interface on open Date: Wed, 11 Apr 2018 14:45:45 -0400 (EDT) Message-ID: <20180411.144545.61566209668287626.davem@davemloft.net> References: <1523362705-30032-1-git-send-email-phil@raspberrypi.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: woojung.huh@microchip.com, UNGLinuxDriver@microchip.com, agraf@suse.de, tbogendoerfer@suse.de, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org To: phil@raspberrypi.org Return-path: In-Reply-To: <1523362705-30032-1-git-send-email-phil@raspberrypi.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Phil Elwell Date: Tue, 10 Apr 2018 13:18:25 +0100 > Commit 92571a1aae40 ("lan78xx: Connect phy early") moves the PHY > initialisation into lan78xx_probe, but lan78xx_open subsequently calls > lan78xx_reset. As well as forcing a second round of link negotiation, > this reset frequently prevents the phy interrupt from being generated > (even though the link is up), rendering the interface unusable. > > Fix this issue by removing the lan78xx_reset call from lan78xx_open. > > Fixes: 92571a1aae40 ("lan78xx: Connect phy early") > Signed-off-by: Phil Elwell Applied and queued up for -stable, thanks.