From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raghuram Chary J Subject: [PATCH v1 net 2/3] lan78xx: Add support to dump lan78xx registers Date: Wed, 11 Apr 2018 12:54:49 +0530 Message-ID: <20180411072450.9809-3-raghuramchary.jallipalli@microchip.com> References: <20180411072450.9809-1-raghuramchary.jallipalli@microchip.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , , To: Return-path: Received: from esa1.microchip.iphmx.com ([68.232.147.91]:63369 "EHLO esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbeDKHVr (ORCPT ); Wed, 11 Apr 2018 03:21:47 -0400 In-Reply-To: <20180411072450.9809-1-raghuramchary.jallipalli@microchip.com> Sender: netdev-owner@vger.kernel.org List-ID: In order to dump lan78xx family registers using ethtool, add support at lan78xx driver level. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Raghuram Chary J --- v0->v1: * Return device regs len if phydev is null. --- drivers/net/usb/lan78xx.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 55a78eb96961..cbeec784f8b8 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -278,6 +278,30 @@ struct lan78xx_statstage64 { u64 eee_tx_lpi_time; }; +u32 lan78xx_regs[] = { + ID_REV, + INT_STS, + HW_CFG, + PMT_CTL, + E2P_CMD, + E2P_DATA, + USB_STATUS, + VLAN_TYPE, + MAC_CR, + MAC_RX, + MAC_TX, + FLOW, + ERR_STS, + MII_ACC, + MII_DATA, + EEE_TX_LPI_REQ_DLY, + EEE_TW_TX_SYS, + EEE_TX_LPI_REM_DLY, + WUCSR +}; + +#define PHY_REG_SIZE (32 * sizeof(u32)) + struct lan78xx_net; struct lan78xx_priv { @@ -1604,6 +1628,34 @@ static int lan78xx_set_pause(struct net_device *net, return ret; } +static int lan78xx_get_regs_len(struct net_device *netdev) +{ + if (!netdev->phydev) + return (sizeof(lan78xx_regs)); + else + return (sizeof(lan78xx_regs) + PHY_REG_SIZE); +} + +static void +lan78xx_get_regs(struct net_device *netdev, struct ethtool_regs *regs, + void *buf) +{ + u32 *data = buf; + int i, j; + struct lan78xx_net *dev = netdev_priv(netdev); + + /* Read Device/MAC registers */ + for (i = 0, j = 0; i < (sizeof(lan78xx_regs) / sizeof(u32)); i++, j++) + lan78xx_read_reg(dev, lan78xx_regs[i], &data[j]); + + if (!netdev->phydev) + return; + + /* Read PHY registers */ + for (i = 0; i < 32; i++, j++) + data[j] = phy_read(netdev->phydev, i); +} + static const struct ethtool_ops lan78xx_ethtool_ops = { .get_link = lan78xx_get_link, .nway_reset = phy_ethtool_nway_reset, @@ -1624,6 +1676,8 @@ static const struct ethtool_ops lan78xx_ethtool_ops = { .set_pauseparam = lan78xx_set_pause, .get_link_ksettings = lan78xx_get_link_ksettings, .set_link_ksettings = lan78xx_set_link_ksettings, + .get_regs_len = lan78xx_get_regs_len, + .get_regs = lan78xx_get_regs, }; static int lan78xx_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd) -- 2.16.2