From: David Miller <davem@davemloft.net>
To: nfont@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com,
tlfalcon@linux.vnet.ibm.com
Subject: Re: [PATCH v2 net 0/2] ibmvnic: Fix parameter change request handling
Date: Thu, 12 Apr 2018 21:52:10 -0400 (EDT) [thread overview]
Message-ID: <20180412.215210.556538656141867668.davem@davemloft.net> (raw)
In-Reply-To: <152345930946.41899.8546547036273488202.stgit@ltcalpine2-lp14.aus.stglabs.ibm.com>
From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Date: Wed, 11 Apr 2018 10:09:26 -0500
> When updating parameters for the ibmvnic driver there is a possibility
> of entering an infinite loop if a return value other that a partial
> success is received from sending the login CRQ.
>
> Also, a deadlock can occur on the rtnl lock if netdev_notify_peers()
> is called during driver reset for a parameter change reset.
>
> This patch set corrects both of these issues by updating the return
> code handling in ibmvnic_login() nand gaurding against calling
> netdev_notify_peers() for parameter change requests.
>
> -Nathan
>
> Updates for V2: Correct spelling mistakes in commit messages.
Series applied, thanks.
prev parent reply other threads:[~2018-04-13 1:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 15:09 [PATCH v2 net 0/2] ibmvnic: Fix parameter change request handling Nathan Fontenot
2018-04-11 15:09 ` [PATCH v2 net 1/2] ibmvnic: Handle all login error conditions Nathan Fontenot
2018-04-11 15:09 ` [PATCH v2 net 2/2] ibmvnic: Do not notify peers on parameter change resets Nathan Fontenot
2018-04-13 1:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412.215210.556538656141867668.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).