From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2 net 0/2] ibmvnic: Fix parameter change request handling Date: Thu, 12 Apr 2018 21:52:10 -0400 (EDT) Message-ID: <20180412.215210.556538656141867668.davem@davemloft.net> References: <152345930946.41899.8546547036273488202.stgit@ltcalpine2-lp14.aus.stglabs.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com, tlfalcon@linux.vnet.ibm.com To: nfont@linux.vnet.ibm.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:60474 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbeDMBwM (ORCPT ); Thu, 12 Apr 2018 21:52:12 -0400 In-Reply-To: <152345930946.41899.8546547036273488202.stgit@ltcalpine2-lp14.aus.stglabs.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Nathan Fontenot Date: Wed, 11 Apr 2018 10:09:26 -0500 > When updating parameters for the ibmvnic driver there is a possibility > of entering an infinite loop if a return value other that a partial > success is received from sending the login CRQ. > > Also, a deadlock can occur on the rtnl lock if netdev_notify_peers() > is called during driver reset for a parameter change reset. > > This patch set corrects both of these issues by updating the return > code handling in ibmvnic_login() nand gaurding against calling > netdev_notify_peers() for parameter change requests. > > -Nathan > > Updates for V2: Correct spelling mistakes in commit messages. Series applied, thanks.