From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 0/4] nfp: improve signal handing on FW waits and flower control message processing Date: Thu, 12 Apr 2018 22:00:55 -0400 (EDT) Message-ID: <20180412.220055.107426667500111939.davem@davemloft.net> References: <20180411234738.6766-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:60708 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753112AbeDMCA5 (ORCPT ); Thu, 12 Apr 2018 22:00:57 -0400 In-Reply-To: <20180411234738.6766-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Wed, 11 Apr 2018 16:47:34 -0700 > The first part of this set aims to improve handling of interrupted > waits. Patch 1 makes waiting for management FW responses > uninterruptible while patch 2 adds a message when signal arrives > while waiting for an NFP mutex. We can't interrupt execution of > FW commands so uninterruptible sleep seems reasonable there. > Exiting a wait for a mutex should be clean and have no side affects > so we are allowing to abort it. Note that both waits have rather > large timeouts (tens of seconds). > > Patches 3 and 4 improve flower offload operation under heavy load. > Currently there is no cap on the number of queued FW notifications. > Some of the notifications have to be processed from a workqueue > which may lead to very large number of messages getting queued > if workqueue never gets a chance to run. Pieter puts a limit > on number of queued messages, tries to drop some messages we ignore > without queuing and process more important messages first. Series applied, thanks Jakub.