From: David Miller <davem@davemloft.net>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, idosch@idosch.org,
roopa@cumulusnetworks.com, eric.dumazet@gmail.com,
weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net-next 07/21] net/ipv6: Save route type in rt6_info
Date: Mon, 16 Apr 2018 15:20:33 -0400 (EDT) [thread overview]
Message-ID: <20180416.152033.1080883507779037027.davem@davemloft.net> (raw)
In-Reply-To: <20180416152255.2256-8-dsahern@gmail.com>
From: David Ahern <dsahern@gmail.com>
Date: Mon, 16 Apr 2018 08:22:41 -0700
> @@ -2394,6 +2395,7 @@ static void addrconf_add_mroute(struct net_device *dev)
> .fc_ifindex = dev->ifindex,
> .fc_dst_len = 8,
> .fc_flags = RTF_UP,
> + .fc_type = RTN_UNICAST,
> .fc_nlinfo.nl_net = dev_net(dev),
> };
>
Multicast route is of type RTN_UNICAST?
All of these cases where passing in a zero initialized value of
fc_type up until this patch. Perhaps you should discuss that in your
commit message a little bit.
Thanks.
next prev parent reply other threads:[~2018-04-16 19:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 15:22 [PATCH net-next 00/21] net/ipv6: Separate data structures for FIB and data path David Ahern
2018-04-16 15:22 ` [PATCH net-next 01/21] net: Move fib_convert_metrics to metrics file David Ahern
2018-04-16 15:22 ` [PATCH net-next 02/21] net: Handle null dst in rtnl_put_cacheinfo David Ahern
2018-04-16 15:22 ` [PATCH net-next 03/21] vrf: Move fib6_table into net_vrf David Ahern
2018-04-16 15:22 ` [PATCH net-next 04/21] net/ipv6: Pass net to fib6_update_sernum David Ahern
2018-04-16 15:22 ` [PATCH net-next 05/21] net/ipv6: Pass net namespace to route functions David Ahern
2018-04-16 15:22 ` [PATCH net-next 06/21] net/ipv6: Move support functions up in route.c David Ahern
2018-04-16 15:22 ` [PATCH net-next 07/21] net/ipv6: Save route type in rt6_info David Ahern
2018-04-16 19:20 ` David Miller [this message]
2018-04-16 19:26 ` David Ahern
2018-04-16 19:50 ` David Ahern
2018-04-16 19:55 ` David Miller
2018-04-16 15:22 ` [PATCH net-next 08/21] net/ipv6: Move nexthop data to fib6_nh David Ahern
2018-04-16 15:22 ` [PATCH net-next 09/21] net/ipv6: Defer initialization of dst to data path David Ahern
2018-04-16 15:22 ` [PATCH net-next 10/21] net/ipv6: move metrics from dst to rt6_info David Ahern
2018-04-16 15:22 ` [PATCH net-next 11/21] net/ipv6: move expires into rt6_info David Ahern
2018-04-16 15:22 ` [PATCH net-next 12/21] net/ipv6: Add fib6_null_entry David Ahern
2018-04-16 15:22 ` [PATCH net-next 13/21] net/ipv6: Add rt6_info create function for ip6_pol_route_lookup David Ahern
2018-04-16 15:22 ` [PATCH net-next 14/21] net/ipv6: Move dst flags to booleans in fib entries David Ahern
2018-04-16 15:22 ` [PATCH net-next 15/21] net/ipv6: Create a neigh_lookup for FIB entries David Ahern
2018-04-16 15:22 ` [PATCH net-next 16/21] net/ipv6: Add gfp_flags to route add functions David Ahern
2018-04-16 15:22 ` [PATCH net-next 17/21] net/ipv6: Cleanup exception and cache route handling David Ahern
2018-04-16 15:22 ` [PATCH net-next 18/21] net/ipv6: introduce fib6_info struct and helpers David Ahern
2018-04-16 15:22 ` [PATCH net-next 19/21] net/ipv6: separate handling of FIB entries from dst based routes David Ahern
2018-04-16 15:22 ` [PATCH net-next 20/21] net/ipv6: Flip FIB entries to fib6_info David Ahern
2018-04-16 15:22 ` [PATCH net-next 21/21] net/ipv6: Remove unused code and variables for rt6_info David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416.152033.1080883507779037027.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=idosch@idosch.org \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=weiwan@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).