From: David Miller <davem@davemloft.net>
To: helgaas@kernel.org
Cc: hkallweit1@gmail.com, bhelgaas@google.com, nic_swsd@realtek.com,
linux-pci@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] PCI: Add two more values for PCIe Max_Read_Request_Size
Date: Mon, 16 Apr 2018 18:06:22 -0400 (EDT) [thread overview]
Message-ID: <20180416.180622.47531730658466358.davem@davemloft.net> (raw)
In-Reply-To: <20180416214204.GD28657@bhelgaas-glaptop.roam.corp.google.com>
From: Bjorn Helgaas <helgaas@kernel.org>
Date: Mon, 16 Apr 2018 16:42:04 -0500
> On Mon, Apr 16, 2018 at 09:37:13PM +0200, Heiner Kallweit wrote:
>> This patch adds missing values for the max read request size.
>> E.g. network driver r8169 uses a value of 4K.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> I'd prefer a subject line with more details, e.g.,
>
> PCI: Add #defines for 2K and 4K Max Read Request Size
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> I suspect conflicts are more likely in r8169.c so it might make more
> sense to route these through the netdev tree. I'd also be happy to
> take them, so let me know if you want me to take them, David.
I'll take them into net-next, thanks Bjorn.
next prev parent reply other threads:[~2018-04-16 22:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 19:35 [PATCH net-next 0/2] PCI: add two more values for PCIe Max_Read_Request_Size and initially use them in r8169 network driver Heiner Kallweit
2018-04-16 19:37 ` [PATCH net-next 1/2] PCI: Add two more values for PCIe Max_Read_Request_Size Heiner Kallweit
2018-04-16 21:42 ` Bjorn Helgaas
2018-04-16 22:06 ` David Miller [this message]
2018-04-16 19:38 ` [PATCH net-next 2/2] r8169: replace magic numbers with PCI MRRS constant Heiner Kallweit
2018-04-16 22:55 ` [PATCH net-next 0/2] PCI: add two more values for PCIe Max_Read_Request_Size and initially use them in r8169 network driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416.180622.47531730658466358.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).