From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/5] net: stmmac: Stop using hard-coded callbacks Date: Mon, 16 Apr 2018 18:50:39 -0400 (EDT) Message-ID: <20180416.185039.2065493119146889779.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Joao.Pinto@synopsys.com, peppe.cavallaro@st.com, alexandre.torgue@st.com To: Jose.Abreu@synopsys.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:47844 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbeDPWul (ORCPT ); Mon, 16 Apr 2018 18:50:41 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Jose Abreu Date: Mon, 16 Apr 2018 16:08:11 +0100 > This a starting point for a cleanup and re-organization of stmmac. > > In this series we stop using hard-coded callbacks along the code and use > instead helpers which are defined in a single place ("hwif.h"). > > This brings several advantages: > 1) Less typing :) > 2) Guaranteed function pointer check > 3) More flexibility > > By 2) we stop using the repeated pattern of: > if (priv->hw->mac->some_func) > priv->hw->mac->some_func(...) > > I didn't check but I expect the final .ko will be bigger with this series > because *all* of function pointers are checked. > > Anyway, I hope this can make the code more readable and more flexible now. > > [resending as per David Miller request] Series applied, thanks Jose.