From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <kubakici@wp.pl>
Subject: Re: [PATCH bpf-next 1/3] bpftool: Add missing prog types and attach
 types
Date: Mon, 16 Apr 2018 16:52:50 -0700
Message-ID: <20180416165250.0c907e90@cakuba.netronome.com>
References: <cover.1523914232.git.rdna@fb.com>
        <5dd2cc619f2eed089e7da9bd7f64031278d6b4fe.1523914232.git.rdna@fb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <ast@kernel.org>, <daniel@iogearbox.net>, <netdev@vger.kernel.org>,
        <kernel-team@fb.com>
To: Andrey Ignatov <rdna@fb.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx4.wp.pl ([212.77.101.11]:4997 "EHLO mx4.wp.pl"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751060AbeDPXw6 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 16 Apr 2018 19:52:58 -0400
In-Reply-To: <5dd2cc619f2eed089e7da9bd7f64031278d6b4fe.1523914232.git.rdna@fb.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 16 Apr 2018 14:41:57 -0700, Andrey Ignatov wrote:
> diff --git a/tools/bpf/bpftool/cgroup.c b/tools/bpf/bpftool/cgroup.c
> index cae32a6..8689916 100644
> --- a/tools/bpf/bpftool/cgroup.c
> +++ b/tools/bpf/bpftool/cgroup.c
> @@ -16,15 +16,28 @@
>  #define HELP_SPEC_ATTACH_FLAGS						\
>  	"ATTACH_FLAGS := { multi | override }"
>  
> -#define HELP_SPEC_ATTACH_TYPES						\
> -	"ATTACH_TYPE := { ingress | egress | sock_create | sock_ops | device }"
> +#define HELP_SPEC_ATTACH_TYPES						       \
> +	"       ATTACH_TYPE := { ingress | egress | sock_create |\n"	       \
> +	"                        sock_ops | stream_parser |\n"		       \
> +	"                        stream_verdict | device | msg_verdict |\n"    \
> +	"                        bind4 | bind6 | connect4 | connect6 |\n"      \
> +	"                        post_bind4 | post_bind6 }"
>  

Would you mind updating the man page in Documentation/ as well?

Thanks!