From: Stephen Hemminger <stephen@networkplumber.org>
To: Jakub Sitnicki <jkbs@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH] iproute: Abort if nexthop cannot be parsed
Date: Mon, 16 Apr 2018 17:00:17 -0700 [thread overview]
Message-ID: <20180416170017.14b5c80f@xeon-e3> (raw)
In-Reply-To: <20180411094311.21097-1-jkbs@redhat.com>
On Wed, 11 Apr 2018 11:43:11 +0200
Jakub Sitnicki <jkbs@redhat.com> wrote:
> Attempt to add a multipath route where a nexthop definition refers to a
> non-existent device causes 'ip' to crash and burn due to stack buffer
> overflow:
>
> # ip -6 route add fd00::1/64 nexthop dev fake1
> Cannot find device "fake1"
> Cannot find device "fake1"
> Cannot find device "fake1"
> ...
> Segmentation fault (core dumped)
>
> Don't ignore errors from the helper routine that parses the nexthop
> definition, and abort immediately if parsing fails.
>
> Signed-off-by: Jakub Sitnicki <jkbs@redhat.com>
Makes sense. Applied
prev parent reply other threads:[~2018-04-17 0:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 9:43 [iproute PATCH] iproute: Abort if nexthop cannot be parsed Jakub Sitnicki
2018-04-17 0:00 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416170017.14b5c80f@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=jkbs@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).