From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [iproute PATCH] iproute: Abort if nexthop cannot be parsed Date: Mon, 16 Apr 2018 17:00:17 -0700 Message-ID: <20180416170017.14b5c80f@xeon-e3> References: <20180411094311.21097-1-jkbs@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Jakub Sitnicki Return-path: Received: from mail-pl0-f65.google.com ([209.85.160.65]:34967 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbeDQAAV (ORCPT ); Mon, 16 Apr 2018 20:00:21 -0400 Received: by mail-pl0-f65.google.com with SMTP id 61-v6so10944459plb.2 for ; Mon, 16 Apr 2018 17:00:21 -0700 (PDT) In-Reply-To: <20180411094311.21097-1-jkbs@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 11 Apr 2018 11:43:11 +0200 Jakub Sitnicki wrote: > Attempt to add a multipath route where a nexthop definition refers to a > non-existent device causes 'ip' to crash and burn due to stack buffer > overflow: > > # ip -6 route add fd00::1/64 nexthop dev fake1 > Cannot find device "fake1" > Cannot find device "fake1" > Cannot find device "fake1" > ... > Segmentation fault (core dumped) > > Don't ignore errors from the helper routine that parses the nexthop > definition, and abort immediately if parsing fails. > > Signed-off-by: Jakub Sitnicki Makes sense. Applied