From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] utils: Do not reset family for default, any, all addresses Date: Mon, 16 Apr 2018 17:01:38 -0700 Message-ID: <20180416170138.6ce01b6d@xeon-e3> References: <20180413163633.1844-1-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, whissi@gentoo.org, Serhey Popovych To: David Ahern Return-path: Received: from mail-pf0-f174.google.com ([209.85.192.174]:34418 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbeDQABm (ORCPT ); Mon, 16 Apr 2018 20:01:42 -0400 Received: by mail-pf0-f174.google.com with SMTP id q9so11300550pff.1 for ; Mon, 16 Apr 2018 17:01:41 -0700 (PDT) In-Reply-To: <20180413163633.1844-1-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 13 Apr 2018 09:36:33 -0700 David Ahern wrote: > Thomas reported a change in behavior with respect to autodectecting > address families. Specifically, 'ip ro add default via fe80::1' > syntax was failing to treat fe80::1 as an IPv6 address as it did in > prior releases. The root causes appears to be a change in family when > the default keyword is parsed. > > 'default', 'any' and 'all' are relevant outside of AF_INET. Leave the > family arg as is for these when setting addr. > > Fixes: 93fa12418dc6 ("utils: Always specify family and ->bytelen in get_prefix_1()") > Reported-by: Thomas Deutschmann > Signed-off-by: David Ahern > Cc: Serhey Popovych Looks good, thanks for fixing. Applied