From: David Miller <davem@davemloft.net>
To: makita.toshiaki@lab.ntt.co.jp
Cc: netdev@vger.kernel.org, jesse@kernel.org
Subject: Re: [PATCH net] vlan: Fix reading memory beyond skb->tail in skb_vlan_tagged_multi
Date: Tue, 17 Apr 2018 14:02:39 -0400 (EDT) [thread overview]
Message-ID: <20180417.140239.267380066356294242.davem@davemloft.net> (raw)
In-Reply-To: <1523958374-2471-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Date: Tue, 17 Apr 2018 18:46:14 +0900
> Syzkaller spotted an old bug which leads to reading skb beyond tail by 4
> bytes on vlan tagged packets.
> This is caused because skb_vlan_tagged_multi() did not check
> skb_headlen.
...
> Fixes: 58e998c6d239 ("offloading: Force software GSO for multiple vlan tags.")
> Reported-and-tested-by: syzbot+0bbe42c764feafa82c5a@syzkaller.appspotmail.com
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Applied and queued up for -stable, thank you.
prev parent reply other threads:[~2018-04-17 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 9:46 [PATCH net] vlan: Fix reading memory beyond skb->tail in skb_vlan_tagged_multi Toshiaki Makita
2018-04-17 18:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417.140239.267380066356294242.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jesse@kernel.org \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).