From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH bpf-next 04/10] [bpf]: make generic xdp compatible w/ bpf_xdp_adjust_tail Date: Tue, 17 Apr 2018 16:06:14 -0700 Message-ID: <20180417230613.vd24e5elzgygegx7@ast-mbp> References: <20180417065131.3632-1-tehnerd@tehnerd.com> <20180417065131.3632-5-tehnerd@tehnerd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexei Starovoitov , Daniel Borkmann , "David S. Miller " , netdev@vger.kernel.org To: "Nikita V. Shirokov" Return-path: Received: from mail-pf0-f170.google.com ([209.85.192.170]:38835 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbeDQXGR (ORCPT ); Tue, 17 Apr 2018 19:06:17 -0400 Received: by mail-pf0-f170.google.com with SMTP id y69so12860973pfb.5 for ; Tue, 17 Apr 2018 16:06:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180417065131.3632-5-tehnerd@tehnerd.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Apr 16, 2018 at 11:51:25PM -0700, Nikita V. Shirokov wrote: > w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as > well (only "decrease" of pointer's location is going to be supported). > changing of this pointer will change packet's size. > for generic XDP we need to reflect this packet's length change by > adjusting skb's tail pointer > > Signed-off-by: Nikita V. Shirokov Acked-by: Alexei Starovoitov pls also change the order of the test/sample patches. they should come last, since they will work only after this one and all other driver support.