From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH bpf-next 08/10] [bpf]: make netronome nfp compatible w/ bpf_xdp_adjust_tail Date: Tue, 17 Apr 2018 16:08:29 -0700 Message-ID: <20180417230828.p745neslgxoy5fus@ast-mbp> References: <20180417065131.3632-1-tehnerd@tehnerd.com> <20180417065131.3632-9-tehnerd@tehnerd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexei Starovoitov , Daniel Borkmann , Jakub Kicinski , netdev@vger.kernel.org To: "Nikita V. Shirokov" Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:38986 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbeDQXIc (ORCPT ); Tue, 17 Apr 2018 19:08:32 -0400 Received: by mail-pl0-f67.google.com with SMTP id e7-v6so12848091plt.6 for ; Tue, 17 Apr 2018 16:08:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180417065131.3632-9-tehnerd@tehnerd.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Apr 16, 2018 at 11:51:29PM -0700, Nikita V. Shirokov wrote: > w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as > well (only "decrease" of pointer's location is going to be supported). > changing of this pointer will change packet's size. > for nfp driver we will just calculate packet's length unconditionally > > Signed-off-by: Nikita V. Shirokov > --- > drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c > index 1eb6549f2a54..d9111c077699 100644 > --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c > +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c > @@ -1722,7 +1722,7 @@ static int nfp_net_rx(struct nfp_net_rx_ring *rx_ring, int budget) > > act = bpf_prog_run_xdp(xdp_prog, &xdp); > > - pkt_len -= xdp.data - orig_data; > + pkt_len = xdp.data_end - xdp.data; Looks correct, but Jakub please review.