From: David Miller <davem@davemloft.net>
To: chris@chrisn.me.uk
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/8] ipconfig: NTP server support, bug fixes, documentation improvements
Date: Wed, 18 Apr 2018 13:59:09 -0400 (EDT) [thread overview]
Message-ID: <20180418.135909.1521396191656904961.davem@davemloft.net> (raw)
In-Reply-To: <20180417205830.1812-1-chris@chrisn.me.uk>
From: Chris Novakovic <chris@chrisn.me.uk>
Date: Tue, 17 Apr 2018 21:58:22 +0100
> - Patch #7 allows for NTP servers to be configured (manually on the
> kernel command line or automatically via DHCP), enabling systems with
> an NFS root filesystem to synchronise their clock before mounting
> their root filesystem.
I think a plain file named /proc/net/ntp is quite confusing. It doesn't
give any indication that it's a special file populated only by ipconfig
and not some general NTP thing the kernel is doing.
I would suggest creating a subdirectory like /proc/net/ipconfig or similar
to put such files. Then the use and meaning is clear.
Also, as noted please remove patch 8 updating CREDITS, this really isn't
done any more.
next prev parent reply other threads:[~2018-04-18 17:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 20:58 [PATCH 0/8] ipconfig: NTP server support, bug fixes, documentation improvements Chris Novakovic
2018-04-17 20:58 ` [PATCH 1/8] ipconfig: Document setting of NIS domain name Chris Novakovic
2018-04-17 20:58 ` [PATCH 2/8] ipconfig: Tidy up reporting of name servers Chris Novakovic
2018-04-17 20:58 ` [PATCH 3/8] ipconfig: BOOTP: Don't request IEN-116 " Chris Novakovic
2018-04-17 20:58 ` [PATCH 4/8] ipconfig: BOOTP: Request CONF_NAMESERVERS_MAX " Chris Novakovic
2018-04-17 20:58 ` [PATCH 5/8] ipconfig: Document /proc/net/pnp Chris Novakovic
2018-04-17 20:58 ` [PATCH 6/8] ipconfig: Correctly initialise ic_nameservers Chris Novakovic
2018-04-17 20:58 ` [PATCH 7/8] ipconfig: Write NTP server IPs to /proc/net/ntp Chris Novakovic
2018-04-17 20:58 ` [PATCH 8/8] CREDITS: Add Chris Novakovic Chris Novakovic
2018-04-17 21:08 ` Cong Wang
2018-04-18 17:59 ` David Miller [this message]
2018-04-18 18:06 ` [PATCH 0/8] ipconfig: NTP server support, bug fixes, documentation improvements Chris Novakovic
2018-04-18 18:12 ` Chris Novakovic
-- strict thread matches above, loose matches on Subject: below --
2018-04-07 4:08 Chris Novakovic
2018-04-07 16:29 ` David Miller
2018-04-07 17:49 ` Chris Novakovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418.135909.1521396191656904961.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris@chrisn.me.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).