From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 net-next] vxlan: fix ttl inherit behavior Date: Wed, 18 Apr 2018 08:50:16 -0700 Message-ID: <20180418085016.7209369d@xeon-e3> References: <1524027948-5395-1-git-send-email-liuhangbin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: network dev , Jiri Benc To: Hangbin Liu Return-path: Received: from mail-pl0-f41.google.com ([209.85.160.41]:44950 "EHLO mail-pl0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753219AbeDRPuU (ORCPT ); Wed, 18 Apr 2018 11:50:20 -0400 Received: by mail-pl0-f41.google.com with SMTP id s13-v6so1358185plq.11 for ; Wed, 18 Apr 2018 08:50:19 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 18 Apr 2018 13:10:49 +0800 Hangbin Liu wrote: > Hi Stephen, > > The patch's subject contains fix. But the kernel feature is applied on net-next. > So I'm not sure if iproute2 net-next is suitable. If you are OK with the patch, > please feel free to apply it on the branch which you think is suitable. > > Thanks > Hangbin > > On 18 April 2018 at 13:05, Hangbin Liu wrote: > > Like kernel net-next commit 72f6d71e491e6 ("vxlan: add ttl inherit support"), > > vxlan ttl inherit should means inherit the inner protocol's ttl value. > > > > But currently when we add vxlan with "ttl inherit", we only set ttl 0, > > which is actually use whatever default value instead of inherit the inner > > protocol's ttl value. > > > > To make a difference with ttl inherit and ttl == 0, we add an attribute > > IFLA_VXLAN_TTL_INHERIT when "ttl inherit" specified. And use "ttl auto" > > to means "use whatever default value", the same behavior with ttl == 0. > > > > Reported-by: Jianlin Shi > > Suggested-by: Jiri Benc > > Signed-off-by: Hangbin Liu When davem merges the feature into net-next, dsa will merge this into iproute2-next. We hold off merging into iproute2 because often the kernel review feedback causes API changes.