From: Stephen Hemminger <stephen@networkplumber.org>
To: Ursula Braun <ubraun@linux.ibm.com>
Cc: Ursula Braun <ubraun@linux.vnet.ibm.com>, netdev@vger.kernel.org
Subject: Re: [Bug 199429] New: smc_shutdown(net/smc/af_smc.c) has a UAF causing null pointer vulnerability.
Date: Wed, 18 Apr 2018 08:55:44 -0700 [thread overview]
Message-ID: <20180418085544.29e54d74@xeon-e3> (raw)
In-Reply-To: <49ed2fa7-cace-12c9-eb57-539cac783cb2@linux.ibm.com>
On Wed, 18 Apr 2018 13:46:20 +0200
Ursula Braun <ubraun@linux.ibm.com> wrote:
> On 04/18/2018 04:56 AM, Stephen Hemminger wrote:
> > This may already be fixed.
> >
> > Begin forwarded message:
> >
> > Date: Wed, 18 Apr 2018 01:52:59 +0000
> > From: bugzilla-daemon@bugzilla.kernel.org
> > To: stephen@networkplumber.org
> > Subject: [Bug 199429] New: smc_shutdown(net/smc/af_smc.c) has a UAF causing null pointer vulnerability.
> >
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=199429
> >
> > Bug ID: 199429
> > Summary: smc_shutdown(net/smc/af_smc.c) has a UAF causing null
> > pointer vulnerability.
> > Product: Networking
> > Version: 2.5
> > Kernel Version: 4.16.0-rc7
> > Hardware: All
> > OS: Linux
> > Tree: Mainline
> > Status: NEW
> > Severity: normal
> > Priority: P1
> > Component: Other
> > Assignee: stephen@networkplumber.org
> > Reporter: 1773876454@qq.com
> > Regression: No
> >
> > Created attachment 275431
> > --> https://bugzilla.kernel.org/attachment.cgi?id=275431&action=edit
> > POC
> >
> > Syzkaller hit 'general protection fault in kernel_sock_shutdown' bug.
> >
> > NET: Registered protocol family 43
>
> Thanks for reporting. This fix is needed here:
>
> net/smc/af_smc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -1314,7 +1314,7 @@ static int smc_shutdown(struct socket *s
> (sk->sk_state != SMC_APPCLOSEWAIT2) &&
> (sk->sk_state != SMC_APPFINCLOSEWAIT))
> goto out;
> - if (smc->use_fallback) {
> + if (smc->use_fallback || sk->sk_state == SMC_LISTEN) {
> rc = kernel_sock_shutdown(smc->clcsock, how);
> sk->sk_shutdown = smc->clcsock->sk->sk_shutdown;
> if (sk->sk_shutdown == SHUTDOWN_MASK)
>
> Kind regards, Ursula
>
Please submit patch to linux net with proper signed-off-by and Fixes tags.
The maintainer (davem) will take care of getting this into upstream and stable.
prev parent reply other threads:[~2018-04-18 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 2:56 Fw: [Bug 199429] New: smc_shutdown(net/smc/af_smc.c) has a UAF causing null pointer vulnerability Stephen Hemminger
2018-04-18 11:46 ` Ursula Braun
2018-04-18 15:55 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418085544.29e54d74@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=ubraun@linux.ibm.com \
--cc=ubraun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).