From: Dominique Martinet <asmadeus@codewreck.org>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
Michal Kubecek <mkubecek@suse.cz>,
netdev@vger.kernel.org,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: tcp hang when socket fills up ?
Date: Wed, 18 Apr 2018 18:36:22 +0900 [thread overview]
Message-ID: <20180418093622.GB7492@nautica> (raw)
In-Reply-To: <20180418083054.GA29358@nautica>
Dominique Martinet wrote on Wed, Apr 18, 2018:
> Jozsef Kadlecsik wrote on Wed, Apr 18, 2018:
> > Yes, the state transition is wrong for simultaneous open, because the
> > tcp_conntracks table is not (cannot be) smart enough. Could you verify the
> > next untested patch?
>
> Thanks for the patch; I'll give it a try (probably won't make it today
> so will report tomorrow)
Actually had time; I can confirm (added printks) we did get in that if
that was pointed at, and we no longer get there now.
The connection no longer gets in invalid state, so that looks like it
nailed it.
I'm now confused what this has to do with tcp_timestamp though, since
setting that off also seemed to work around the issue, but if we get
something like that in I'll be happy anyway.
Big props to everyone involved, I would have taken much longer alone,
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2018-04-18 9:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 9:07 tcp hang when socket fills up ? Dominique Martinet
2018-04-13 9:42 ` Dominique Martinet
2018-04-13 15:01 ` Eric Dumazet
2018-04-13 16:32 ` Michal Kubecek
2018-04-14 1:09 ` Dominique Martinet
2018-04-14 1:39 ` Eric Dumazet
2018-04-14 1:55 ` Dominique Martinet
2018-04-16 1:47 ` Dominique Martinet
2018-04-16 2:26 ` Eric Dumazet
2018-04-16 3:55 ` Dominique Martinet
2018-04-16 4:03 ` Dominique Martinet
2018-04-16 11:01 ` Florian Westphal
2018-04-17 3:52 ` Dominique Martinet
2018-04-17 5:28 ` Eric Dumazet
2018-04-17 6:52 ` Michal Kubecek
2018-04-17 9:20 ` Michal Kubecek
2018-04-17 12:34 ` Dominique Martinet
2018-04-17 13:00 ` Michal Kubecek
2018-04-17 13:29 ` Florian Westphal
2018-04-18 8:13 ` Jozsef Kadlecsik
2018-04-18 8:30 ` Dominique Martinet
2018-04-18 9:36 ` Dominique Martinet [this message]
2018-04-18 10:27 ` Jozsef Kadlecsik
2018-04-18 11:30 ` Dominique Martinet
2018-04-18 11:37 ` Jozsef Kadlecsik
2018-04-16 20:43 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418093622.GB7492@nautica \
--to=asmadeus@codewreck.org \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=marcelo.leitner@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).