From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joachim Nilsson Subject: Re: [RFC PATCH] net: bridge: multicast querier per VLAN support Date: Wed, 18 Apr 2018 15:25:06 +0200 Message-ID: <20180418132505.GA16964@troglobit> References: <20180418120713.GA10742@troglobit> <20180418130718.GA16044@troglobit> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Stephen Hemminger , roopa To: Nikolay Aleksandrov Return-path: Received: from mail-lf0-f52.google.com ([209.85.215.52]:35497 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753296AbeDRNZJ (ORCPT ); Wed, 18 Apr 2018 09:25:09 -0400 Received: by mail-lf0-f52.google.com with SMTP id r125-v6so2627731lfe.2 for ; Wed, 18 Apr 2018 06:25:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Apr 18, 2018 at 04:14:26PM +0300, Nikolay Aleksandrov wrote: > We want to avoid sysfs in general, all of networking config and stats > are moving to netlink. It is better controlled and structured for such > changes, also provides nice interfaces for automatic type checks etc. Aha, didn't know that. Thanks! :) > Also (but a minor reason) there is no tree/entity in sysfs for the vlans > where to add this. It will either have to be a file which does some > format string hack (like us currently) or will need to add new tree for > them which I'd really like to avoid for the bridge. Yup, I did some ugly sysfs patches to read queriers per VLAN like that, just for some basic feedback. Really awful, although easy to debug because of it being a simple file ... (I guess I'll have to make friends withe Netlink.) > [..] > Also after my vlan rhastable change, we have per-vlan context even today > (e.g. per-vlan stats use it) so we'll just extend that. Interesting, this I'll have to look at in more detail!