From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH bpf-next v2 02/11] bpf: make generic xdp compatible w/ bpf_xdp_adjust_tail Date: Wed, 18 Apr 2018 14:48:18 +0200 Message-ID: <20180418144818.0bcba1f9@redhat.com> References: <20180418042951.17183-1-tehnerd@tehnerd.com> <20180418042951.17183-3-tehnerd@tehnerd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: brouer@redhat.com, Alexei Starovoitov , Daniel Borkmann , "David S. Miller " , netdev@vger.kernel.org To: "Nikita V. Shirokov" Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47474 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753442AbeDRMsW (ORCPT ); Wed, 18 Apr 2018 08:48:22 -0400 In-Reply-To: <20180418042951.17183-3-tehnerd@tehnerd.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 17 Apr 2018 21:29:42 -0700 "Nikita V. Shirokov" wrote: > w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as > well (only "decrease" of pointer's location is going to be supported). > changing of this pointer will change packet's size. > for generic XDP we need to reflect this packet's length change by > adjusting skb's tail pointer > > Acked-by: Alexei Starovoitov You are missing your own Signed-off-by: line on all of the patches. BTW, thank you for working on this! It have been on my todo-list for a while now! _After_ this patchset, I would like to see adding support for "increasing" the data_end location to create a larger packet. For that we should likely add a data_hard_end pointer. This, would also be helpful in cpu_map_build_skb() to know the data_hard_end, to determine the frame size (as some driver doesn't use PAGE_SIZE frames, ixgbe). -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer