From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] net: stmmac: Disable ACS Feature for GMAC >= 4
Date: Thu, 19 Apr 2018 13:34:28 -0400 (EDT)
Message-ID: <20180419.133428.354613663042783746.davem@davemloft.net>
References: <1c69d3cabd8d26648c327d72a0a58d3d879cfc34.1524045087.git.joabreu@synopsys.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, Joao.Pinto@synopsys.com,
        peppe.cavallaro@st.com, alexandre.torgue@st.com
To: Jose.Abreu@synopsys.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:32846 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753148AbeDSRea (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 19 Apr 2018 13:34:30 -0400
In-Reply-To: <1c69d3cabd8d26648c327d72a0a58d3d879cfc34.1524045087.git.joabreu@synopsys.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Wed, 18 Apr 2018 10:57:55 +0100

> ACS Feature is currently enabled for GMAC >= 4 but the llc_snap status
> is never checked in descriptor rx_status callback. This will cause
> stmmac to always strip packets even that ACS feature is already
> stripping them.
> 
> Lets be safe and disable the ACS feature for GMAC >= 4 and always strip
> the packets for this GMAC version.
> 
> Fixes: 477286b53f55 ("stmmac: add GMAC4 core support")
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Joao Pinto <jpinto@synopsys.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> ---
> Hi David,
> 
> Requesting this to go up for stable also. I think its for v4.7+ but if you
> could cross-check it would be great! Let me know if you need any more
> info for queueing this.

Yeah v4.7+ looks about right.

Applied and queued up for -stable, thanks.