From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net 2/3] net: sched: ife: handle malformed tlv length
Date: Thu, 19 Apr 2018 15:30:01 -0400 (EDT)
Message-ID: <20180419.153001.1773998639779201296.davem@davemloft.net>
References: <20180418213534.6215-1-aring@mojatatu.com>
        <20180418213534.6215-3-aring@mojatatu.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: yotam.gi@gmail.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
        jiri@resnulli.us, yuvalm@mellanox.com, netdev@vger.kernel.org,
        kernel@mojatatu.com
To: aring@mojatatu.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:34370 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751764AbeDSTaE (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 19 Apr 2018 15:30:04 -0400
In-Reply-To: <20180418213534.6215-3-aring@mojatatu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Alexander Aring <aring@mojatatu.com>
Date: Wed, 18 Apr 2018 17:35:33 -0400

> @@ -92,12 +92,43 @@ struct meta_tlvhdr {
>  	__be16 len;
>  };
>  
> +static inline bool __ife_tlv_meta_valid(const unsigned char *skbdata,
> +					const unsigned char *ifehdr_end)
> +{

Please do not use inline in foo.c files, let the compiler decide.