From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH bpf-next v2 9/9] tools/bpf: add a test_progs test case
 for bpf_get_stack helper
Date: Wed, 18 Apr 2018 21:39:54 -0700
Message-ID: <20180419043953.fcv33e2glomg33gp@ast-mbp>
References: <20180418165444.2263237-1-yhs@fb.com>
 <20180418165444.2263237-10-yhs@fb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: ast@fb.com, daniel@iogearbox.net, netdev@vger.kernel.org,
        kernel-team@fb.com
To: Yonghong Song <yhs@fb.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f51.google.com ([74.125.83.51]:36935 "EHLO
        mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750737AbeDSEj5 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 19 Apr 2018 00:39:57 -0400
Received: by mail-pg0-f51.google.com with SMTP id r14so1904642pgq.4
        for <netdev@vger.kernel.org>; Wed, 18 Apr 2018 21:39:57 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180418165444.2263237-10-yhs@fb.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Apr 18, 2018 at 09:54:44AM -0700, Yonghong Song wrote:
> The test_stacktrace_map is enhanced to call bpf_get_stack
> in the helper to get the stack trace as well.
> The stack traces from bpf_get_stack and bpf_get_stackid
> are compared to ensure that for the same stack as
> represented as the same hash, their ip addresses
> must be the same.
> 
> Signed-off-by: Yonghong Song <yhs@fb.com>

could you please add a test for bpf_get_stack() with buildid as well?
I think patch 2 implementes it correctly, but would be good to have a test for it.