From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH iproute2-next 2/2] gre/gre6: allow clearing
 {,i,o}{key,seq,csum} flags
Date: Thu, 19 Apr 2018 12:40:15 +0200
Message-ID: <20180419104015.GA13527@bistromath.localdomain>
References: <a1bfb22fa7ce8940e7b4430d1aa0a9ed81b33d6f.1524133203.git.sd@queasysnail.net>
 <bdb1a801f15694d884f823e6caa6b1d6022173dd.1524133203.git.sd@queasysnail.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: dsahern@gmail.com
To: netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36296 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751386AbeDSKkV (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 19 Apr 2018 06:40:21 -0400
Content-Disposition: inline
In-Reply-To: <bdb1a801f15694d884f823e6caa6b1d6022173dd.1524133203.git.sd@queasysnail.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

2018-04-19, 12:22:42 +0200, Sabrina Dubroca wrote:
> @@ -210,28 +210,49 @@ get_failed:
>  			iflags |= GRE_KEY;
>  			oflags |= GRE_KEY;
>  			ikey = okey = tnl_parse_key("key", *argv);
> +		} else if (!matches(*argv, "nokey")) {
> +			iflags &= ~GRE_KEY;
> +			oflags &= ~GRE_KEY;
>  		} else if (!matches(*argv, "ikey")) {
>  			NEXT_ARG();
>  			iflags |= GRE_KEY;
>  			ikey = tnl_parse_key("ikey", *argv);
> +		} else if (!matches(*argv, "noikey")) {
> +			iflags &= ~GRE_KEY;
>  		} else if (!matches(*argv, "okey")) {
>  			NEXT_ARG();
>  			oflags |= GRE_KEY;
>  			okey = tnl_parse_key("okey", *argv);
> +		} else if (!matches(*argv, "noikey")) {
> +			iflags &= ~GRE_KEY;

Sorry, posted the wrong version. I'll send v2 after I've had a bucket
of coffee.

-- 
Sabrina