From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
Ganesh GR <ganeshgr@chelsio.com>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>,
Indranil Choudhury <indranil@chelsio.com>
Subject: Re: [PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel
Date: Thu, 19 Apr 2018 20:26:06 +0530 [thread overview]
Message-ID: <20180419145605.GA30325@chelsio.com> (raw)
In-Reply-To: <20180419082456.GA8617@kroah.com>
On Thursday, April 04/19/18, 2018 at 13:54:56 +0530, Greg KH wrote:
> On Tue, Apr 17, 2018 at 01:14:17PM +0530, Rahul Lakkireddy wrote:
> > +config PROC_VMCORE_DEVICE_DUMP
> > + bool "Device Hardware/Firmware Log Collection"
> > + depends on PROC_VMCORE
> > + default y
>
> Only things that require the machine to keep working should be 'default
> y', please remove this, it's an option.
>
Ok. Will fix this.
> > + help
> > + Device drivers can collect the device specific snapshot of
> > + their hardware or firmware before they are initialized in
> > + crash recovery kernel. If you say Y here, the device dumps
> > + will be added as ELF notes to /proc/vmcore
>
> Which exact "device drivers" are you referring to here?
>
The API is generic enough to collect any type of device's dump. Any
driver that wants to collect its underlying hardware/firmware dump
can use the API. In our case, cxgb4 driver collects dumps of the
underlying Chelsio network devices.
Thanks,
Rahul
next prev parent reply other threads:[~2018-04-19 14:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 7:44 [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel Rahul Lakkireddy
2018-04-17 7:44 ` [PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel Rahul Lakkireddy
2018-04-19 8:24 ` Greg KH
2018-04-19 14:56 ` Rahul Lakkireddy [this message]
[not found] ` <cover.1523950321.git.rahul.lakkireddy-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2018-04-17 7:44 ` [PATCH net-next v4 2/3] vmcore: append device dumps to vmcore as elf notes Rahul Lakkireddy
2018-04-17 7:44 ` [PATCH net-next v4 3/3] cxgb4: collect hardware dump in second kernel Rahul Lakkireddy
2018-04-18 6:15 ` [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel Dave Young
[not found] ` <20180418061546.GA4551-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2018-04-18 12:31 ` Rahul Lakkireddy
2018-04-18 14:28 ` Eric W. Biederman
2018-04-18 15:07 ` Rahul Lakkireddy
2018-04-19 1:40 ` Dave Young
2018-04-19 14:27 ` Rahul Lakkireddy
2018-04-19 14:53 ` Eric W. Biederman
2018-04-20 13:06 ` Rahul Lakkireddy
2018-04-20 13:36 ` Eric W. Biederman
2018-04-20 14:51 ` Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419145605.GA30325@chelsio.com \
--to=rahul.lakkireddy@chelsio.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=ganeshgr@chelsio.com \
--cc=gregkh@linuxfoundation.org \
--cc=indranil@chelsio.com \
--cc=kexec@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=stephen@networkplumber.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).